Bug 262473

Summary:	[Win] Fix -Wundef and -Wnonportable-include-path compiler warnings
Product:	WebKit	Reporter:	Fujii Hironori <fujii.hironori>
Component:	Web Template Framework	Assignee:	Fujii Hironori <fujii.hironori>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Fujii Hironori

Reported 2023-10-01 23:40:26 PDT

Let's remove -Wno-undef and -Wno-nonportable-include-path for clang-cl by fixing compiler warnings. C:\home\webkit\gb\WebKitBuild\Debug\WTF\Headers\wtf/Brigand.h(41,7): warning: '__GNUC__' is not defined, evaluates to 0 [-Wundef] 41 | #elif __GNUC__ | ^ 1 warning generated. C:\home\webkit\gb\Source\WebCore\platform\network\curl\CookieJarDB.cpp(27,10): warning: non-portable path to file '"CookieJar.h"'; specified path differs in case from file name on disk [-Wnonportable-include-path] 27 | #include "cookieJar.h" | ^~~~~~~~~~~~~ | "CookieJar.h" 1 warning generated.

Attachments
Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2023-10-01 23:47:24 PDT

Pull request: https://github.com/WebKit/WebKit/pull/18485

EWS

Comment 2 2023-10-02 14:27:34 PDT

Committed 268748@main (fed6dd1cc386): <https://commits.webkit.org/268748@main> Reviewed commits have been landed. Closing PR #18485 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2023-10-02 14:28:17 PDT

<rdar://problem/116366974>

Note You need to log in before you can comment on or make changes to this bug.