Bug 262504

Summary: [git-webkit] Rely on cache when identifier and branch specified
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Jonathan Bedard
Reported 2023-10-02 14:16:23 PDT
When defining a commit, clients may specify both an identifier and a branch to the Git object's commit function. In the event the identifier they specify is an integer (instead of the traditional '###.###@<branch>' string) and the branch specified via the 'branch' argument, we don't consult the cache. Notably, this is the way that the 'find' function will pass arguments to 'commit'. We should consult the cache in this circumstance.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-10-02 14:16:38 PDT
Jonathan Bedard
Comment 2 2023-10-02 14:32:51 PDT
EWS
Comment 3 2023-10-02 14:54:58 PDT
Committed 268750@main (6a5dbe08f760): <https://commits.webkit.org/268750@main> Reviewed commits have been landed. Closing PR #18511 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.