Bug 262504
| Summary: | [git-webkit] Rely on cache when identifier and branch specified | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
When defining a commit, clients may specify both an identifier and a branch to the Git object's commit function. In the event the identifier they specify is an integer (instead of the traditional '###.###@<branch>' string) and the branch specified via the 'branch' argument, we don't consult the cache. Notably, this is the way that the 'find' function will pass arguments to 'commit'. We should consult the cache in this circumstance.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/116366226>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/18511
EWS
Committed 268750@main (6a5dbe08f760): <https://commits.webkit.org/268750@main>
Reviewed commits have been landed. Closing PR #18511 and removing active labels.