Bug 262587

Summary: WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 262601    
Bug Blocks:    

Chris Dumez
Reported 2023-10-03 16:54:17 PDT
WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character. It is a UChar, which is guaranteed to be 16 bit.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-10-03 16:57:23 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18597
EWS
Comment 2 2023-10-03 20:21:25 PDT
Committed 268822@main (ee2c3461bc42): <https://commits.webkit.org/268822@main> Reviewed commits have been landed. Closing PR #18597 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-10-03 20:22:15 PDT
<rdar://problem/116441712>
WebKit Commit Bot
Comment 4 2023-10-03 21:05:34 PDT
Re-opened since this is blocked by bug 262601
Chris Dumez
Comment 5 2023-10-03 21:11:10 PDT
Likely not safe.
Note You need to log in before you can comment on or make changes to this bug.