Bug 262713

Summary: REGRESSION(268913@main) clang requires std namespace for nullptr_t
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Web Template FrameworkAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=262678

Description Lauro Moura 2023-10-05 11:56:33 PDT
SSIA

Example: https://godbolt.org/z/dz75q7h6T

Patch incoming.
Comment 1 Lauro Moura 2023-10-05 11:57:31 PDT
Sample error message in WPE build (for reference)

In file included from /app/webkit/Source/WTF/wtf/NativePromise.cpp:27:
/app/webkit/Source/WTF/wtf/NativePromise.h:892:78: error: use of undeclared identifier 'nullptr_t'; did you mean 'std::nullptr_t'?
                    return invokeWithVoidOrWithArg(WTFMove(resolveFunction), nullptr_t());
                                                                             ^
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.2.0/../../../../include/c++/12.2.0/x86_64-unknown-linux-gnu/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
In file included from /app/webkit/Source/WTF/wtf/NativePromise.cpp:27:
/app/webkit/Source/WTF/wtf/NativePromise.h:913:82: error: use of undeclared identifier 'nullptr_t'; did you mean 'std::nullptr_t'?
                    return invokeWithVoidOrWithArg(thisVal.get(), resolveMethod, nullptr_t());
                                                                                 ^
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.2.0/../../../../include/c++/12.2.0/x86_64-unknown-linux-gnu/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
2 errors generated.
Comment 2 Lauro Moura 2023-10-05 12:03:11 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18708
Comment 3 EWS 2023-10-05 17:25:50 PDT
Committed 268954@main (e8659754092e): <https://commits.webkit.org/268954@main>

Reviewed commits have been landed. Closing PR #18708 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-10-05 17:26:22 PDT
<rdar://problem/116551780>