Bug 262750

Summary: [ Sonoma arm64 ] css3/filters/effect-blur-hw.html is a consistent failure
Product: WebKit Reporter: Karl Rackler <rackler>
Component: New BugsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
effect-blur-hw-diff
none
effect-blur-hw-actual
none
effect-blur-hw-expected none

Description Karl Rackler 2023-10-05 17:26:43 PDT 
Description:
css3/filters/effect-blur-hw.html

Is a constant failure on macOS ToT and since Sonoma bring-up.
The expected effect blur has a blurred border that appears missing on the actual images 2, 3, and 4.

History:
https://results.webkit.org/?suite=layout-tests&test=css3%2Ffilters%2Feffect-blur-hw.html&version_name=Sonoma&architecture=arm64

Diff:
0.26% image difference.
*Diff images attached*
https://build.webkit.org/results/Apple-Sonoma-Debug-AppleSilicon-WK2-Tests/268933@main%20(102)/css3/filters/effect-blur-hw-diffs.html
Comment 1 Radar WebKit Bug Importer 2023-10-05 17:28:44 PDT 
<rdar://problem/116551869>
Comment 2 Karl Rackler 2023-10-05 17:29:47 PDT 
Created attachment 468084 [details]
effect-blur-hw-diff
Comment 3 Karl Rackler 2023-10-05 17:30:13 PDT 
Created attachment 468085 [details]
effect-blur-hw-actual
Comment 4 Karl Rackler 2023-10-05 17:30:43 PDT 
Created attachment 468086 [details]
effect-blur-hw-expected
Comment 5 EWS 2023-10-05 17:42:32 PDT 
Test gardening commit 268956@main (b5334a81ce49): <https://commits.webkit.org/268956@main>

Reviewed commits have been landed. Closing PR #18735 and removing active labels.
Comment 6 Simon Fraser (smfr) 2023-10-05 17:54:43 PDT 
Need some more tolerance.
Comment 7 Said Abou-Hallawa 2023-10-09 15:48:49 PDT 
I do not think this is a regression. The test needs more tolerance mainly because the last image was clipped in the expected page. Its filter has a GaussianBlur effect with std = 10. The height of the target element is 90 pixels so the filter element has outsets of 10% of the target element. So the top and bottom outset are both equal to 9 pixels. This outset is not enough for this filter. So the fix is to increase the dimension of the filter by 20% instead.
Comment 8 Said Abou-Hallawa 2023-10-09 16:00:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18870
Comment 9 EWS 2023-10-10 10:35:49 PDT 
Committed 269152@main (485231878ea3): <https://commits.webkit.org/269152@main>

Reviewed commits have been landed. Closing PR #18870 and removing active labels.