| Summary: | REGRESSION(265870.8@safari-7616-branch): [GTK] Cannot load Unity WebGL apps due to access control checks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jim Mason <jmason> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bugs-noreply, cdumez, chirag_m_shah, mcatanzaro, seanmi, webkit-bug-importer, xry111 |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=258895 | ||
|
Description
Jim Mason
2023-10-06 04:45:10 PDT
Bisected this. Only the Safari and GTK/WPE branches are affected because this commit has not landed in main yet. a209cbf453978e3ea809d36f684a36f36ff301c5 is the first bad commit commit a209cbf453978e3ea809d36f684a36f36ff301c5 Author: Chirag M Shah <chirag_m_shah@apple.com> Date: Mon Jul 10 18:24:09 2023 -0700 Cherry-pick 265870.8@safari-7616-branch (551b1fd24102). https://bugs.webkit.org/show_bug.cgi?id=258712 Fix stack-overflow when dealing with blobURL(s) https://bugs.webkit.org/show_bug.cgi?id=258895 rdar://111440239 Reviewed by Chris Dumez. This change fixes the stack overflow when checking for whether a blobURL is secure. * Source/WebCore/fileapi/BlobURL.cpp: (WebCore::BlobURL::isSecureBlobURL): * Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/265870.8@safari-7616-branch Source/WebCore/fileapi/BlobURL.cpp | 3 ++- Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) The culprit has shipped in Safari 17, and I cannot reproduce the issue there. So the regression must be Gtk specific? Strange, but I've seen stranger.... It's more likely to be branch-specific rather than port-specific. Likely we're either (a) missing some other unknown but required change from safari-7616-branch, or (b) more likely the change is incompatible with some other unknown change on main. We'll be able to find out after this change has landed in main. (In reply to Michael Catanzaro from comment #4) > It's more likely to be branch-specific rather than port-specific. Likely > we're either (a) missing some other unknown but required change from > safari-7616-branch, or (b) more likely the change is incompatible with some > other unknown change on main. > > We'll be able to find out after this change has landed in main. I think it is likely the branch change is incompatible with some changes that were done on trunk. I haven't had time to investigate yet though. (In reply to Chris Dumez from comment #5) > (In reply to Michael Catanzaro from comment #4) > > It's more likely to be branch-specific rather than port-specific. Likely > > we're either (a) missing some other unknown but required change from > > safari-7616-branch, or (b) more likely the change is incompatible with some > > other unknown change on main. > > > > We'll be able to find out after this change has landed in main. > > I think it is likely the branch change is incompatible with some changes > that were done on trunk. I haven't had time to investigate yet though. See https://github.com/WebKit/WebKit/pull/18859 Reverted this on webkitglib/2.42 branch. Closing. I'm guessing 266247@main was the commit that fixed the stack overflow on main, though I'm not certain. *** Bug 264263 has been marked as a duplicate of this bug. *** *** Bug 264201 has been marked as a duplicate of this bug. *** |