| Summary: | [GTK][WPE] Enable libbacktrace support | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <philn> |
| Component: | WebKitGTK | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino, emilio, mcatanzaro, vitaly |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Philippe Normand
2023-10-07 02:24:00 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18807 Committed 269037@main (343ea784deb2): <https://commits.webkit.org/269037@main> Reviewed commits have been landed. Closing PR #18807 and removing active labels. This broke https://build.webkit.org/#/builders/46 -- Could NOT find LibBacktrace (missing: LIBBACKTRACE_INCLUDE_DIR LIBBACKTRACE_LIBRARY) CMake Error at Source/cmake/OptionsGTK.cmake:478 (message): libbacktrace is required for USE_LIBBACKTRACE Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:232 (include) CMakeLists.txt:21 (include) Not sure what to do? Well we either change the LTS bots' configuration to build without libbacktrace, or install libbacktrace on the bots. I don't think this is urgent; they're not test bots, so it's not like we're losing test results every hour they are turned off. Can deal with it next week IMO. FYI, an interruption of the WebKitGTK Ubuntu LTS build bot will likely cause an interruption of WebKit Search (https://searchfox.org/wubkat/source/) as well, because both bots build WebKitGTK with a similar configuration (--no-experimental-features plus a few features disabled). While the other bots are not critical, I think an interruption of WebKit Search is more important since many people use it daily. I searched for a libbacktrace package in Ubuntu and it doesn't seem to exist (neither 20.04 or 22.04). Libbakctrace is installed directly from a git repository (https://github.com/WebKit/WebKit/blob/main/Tools/buildstream/elements/sdk/libbacktrace.bst). A potential fix could be to install this package as a JHBuild dependency, but that wouldn't be enough for bots that do not use JHBuild and build only using system libraries (--no-experimental-features). In this case, those bots have to build with --USE_LIBBACKTRACE=OFF. I can change the bots settings to build with this flag disabled. |