Bug 262839

Summary: HAVE_SAFARI_SERVICES_FRAMEWORK should be renamed to USE_SAFARI_SERVICES_FRAMEWORK
Product: WebKit Reporter: Matthew Benedict <uint2048>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Enhancement CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Matthew Benedict
Reported 2023-10-07 07:39:46 PDT
There's already a FIXME for this issue in the code (https://github.com/WebKit/WebKit/blob/5870261ff9b3f700cae3614190213e0dc5f0477c/Source/WTF/wtf/PlatformHave.h#L439) but I was unable to find a Bugzilla issue for this. The name of HAVE_SAFARI_SERVICES_FRAMEWORK implies it does not exist in macOS, but WebKit is simply not using it, so it would make more sense as USE_SAFARI_SERVICES_FRAMEWORK.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-10-14 07:40:15 PDT
<rdar://problem/116958630>
Note You need to log in before you can comment on or make changes to this bug.