Bug 262898
| Summary: | run-webkit-tests: check for crash log without leading period | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
run-webkit-tests: check for crash log without leading period.
When ReportCrash writes out a crash log, the initial file name contains a leading period ("." or dot) character, then the file is renamed to the same file name without the leading period when it's done being written.
The run-webkit-tests tool sometimes finds the crash log with the leading period in the name, but then can't make a copy of the crash log because the file was renamed before it copies it.
Example:
PR https://github.com/WebKit/WebKit/pull/18195
EWS https://ews-build.webkit.org/#/builders/10/builds/19515
Layout test result https://ews-build.s3-us-west-2.amazonaws.com/macOS-Monterey-Release-WK1-Tests-EWS/71cbcf72-19515/results.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
One way to avoid missing crash logs is to check (once) for the same crash log without the leading period character when copying the file if it can't find it the first time.
Radar WebKit Bug Importer
<rdar://problem/116687173>
Alexey Proskuryakov
I don't think that this is the right thing to do long term. We will still have a race with CrashTracer, as it generates the crash report.
What we need is to monitor the state of CrashTracer to get all the necessary reports.
David Kilzer (:ddkilzer)
Yep, it's a workaround. But it would help with a certain subset of missing crash logs in the meantime.