Bug 263041

Summary: REGRESSION(iOS17): [ iOS 17 ] 5X http/tests/css/css-masking/mask- (Layout-tests) are constant ImageOnlyFailures
Product: WebKit Reporter: Robert Jenner <jenner>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Robert Jenner 2023-10-11 15:00:19 PDT
The following 5X http/tests/css/css-masking/mask- (Layout-tests) are constant ImageOnlyFailures on iOS17:

http/tests/css/css-masking/mask-external-svg-fragment.html 
http/tests/css/css-masking/mask-external-svg-image.html 
http/tests/css/css-masking/mask-external-svg-mask.html 
http/tests/css/css-masking/mask-inline-svg-image.html 
http/tests/css/css-masking/mask-inline-svg-mask.html 

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fcss%2Fcss-masking%2Fmask-external-svg-fragment.html&test=http%2Ftests%2Fcss%2Fcss-masking%2Fmask-external-svg-image.html&test=http%2Ftests%2Fcss%2Fcss-masking%2Fmask-external-svg-mask.html&test=http%2Ftests%2Fcss%2Fcss-masking%2Fmask-inline-svg-image.html&test=http%2Ftests%2Fcss%2Fcss-masking%2Fmask-inline-svg-mask.html


History link indicates that these were not failing on iOS 16.

The Image Diffs all indicate that these are all off by .01% as observed at the following link:
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/269211@main%20(123)/http/tests/css/css-masking/mask-external-svg-fragment-diffs.html

Below are links for all of the ImageDiffs:
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/269211@main%20(123)/http/tests/css/css-masking/mask-external-svg-fragment-diff.png
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/269211@main%20(123)/http/tests/css/css-masking/mask-external-svg-image-diff.png
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/269211@main%20(123)/http/tests/css/css-masking/mask-external-svg-mask-diff.png
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/269211@main%20(123)/http/tests/css/css-masking/mask-inline-svg-image-diff.png
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/269211@main%20(123)/http/tests/css/css-masking/mask-inline-svg-mask-diff.png
Comment 1 Radar WebKit Bug Importer 2023-10-11 15:01:56 PDT
<rdar://problem/116831359>
Comment 2 Robert Jenner 2023-10-11 16:07:02 PDT
I was able to reproduce at iOS 17 Release ToT running the test as follows:

run-webkit-tests --iOS-simulator <test_goes_here>

When I reproduced this was the output:

[1/5] http/tests/css/css-masking/mask-external-svg-fragment.html failed unexpectedly (reference mismatch maxDifference=5; totalPixels=8248)
[2/5] http/tests/css/css-masking/mask-external-svg-image.html failed unexpectedly (reference mismatch maxDifference=5; totalPixels=8248)
[3/5] http/tests/css/css-masking/mask-external-svg-mask.html failed unexpectedly (reference mismatch maxDifference=5; totalPixels=8248)
[4/5] http/tests/css/css-masking/mask-inline-svg-image.html failed unexpectedly (reference mismatch maxDifference=5; totalPixels=8248)
[5/5] http/tests/css/css-masking/mask-inline-svg-mask.html failed unexpectedly (reference mismatch maxDifference=5; totalPixels=8248)
Comment 3 Robert Jenner 2023-10-11 16:07:48 PDT
I feel like these MAY just need pixel tolerance adjustments. But I am going to ask Said if that is true, or if this is indicative of another issue.
Comment 4 EWS 2023-10-12 16:51:22 PDT
Committed 269280@main (82b3e4c30781): <https://commits.webkit.org/269280@main>

Reviewed commits have been landed. Closing PR #19008 and removing active labels.