Bug 263193

Summary: Build error when CSS_BOX_DECORATION_BREAK is disabled
Product: WebKit Reporter: perry <perryuwang>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

perry
Reported 2023-10-16 06:09:19 PDT
There is a build error when CSS_BOX_DECORATION_BREAK is disabled on LineBuilder::candidateContentForLine.
Attachments
Patch (1.30 KB, patch)
2023-10-16 06:22 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-10-16 06:22:44 PDT
Created attachment 468228 [details] Patch
EWS
Comment 2 2023-10-16 08:14:46 PDT
Committed 269362@main (f2560fbccb1a): <https://commits.webkit.org/269362@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468228 [details].
Radar WebKit Bug Importer
Comment 3 2023-10-16 08:15:15 PDT
<rdar://problem/117018650>
perry
Comment 4 2023-10-17 05:42:01 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19162
Simon Fraser (smfr)
Comment 5 2023-10-17 12:20:01 PDT
CSS_BOX_DECORATION_BREAK has been enabled for 10 years. Why are you building with it turned off? Can we just remove it?
Note You need to log in before you can comment on or make changes to this bug.