Bug 263293

Summary:	git-webkit warns "environment: line 1: .ToolsScriptsgit-webkit: command not found" with Windows Git
Product:	WebKit	Reporter:	Fujii Hironori <Hironori.Fujii>
Component:	Tools / Tests	Assignee:	Fujii Hironori <Hironori.Fujii>
Status:	NEW ---
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Fujii Hironori 2023-10-17 17:26:43 PDT

git-webkit warns "environment: line 1: .ToolsScriptsgit-webkit: command not found" with Windows Git

git-webkit delete-pr-branches and git-webkit pr reports the warning.

PS C:\home\webkit\gc> python .\Tools\Scripts\git-webkit delete-pr-branches
Deleted branch eng/REGRESSION269405mainWin-OPTNOICF-linker-switch-is-duplicated-for-debug-build (was fdaaeda4c9bb).
environment: line 1: .ToolsScriptsgit-webkit: command not found
Pushing to fork, which has no classification. Treating it as a public remote
No novel content being pushed
To https://github.com/fujii/WebKit.git
 - [deleted]                   eng/REGRESSION269405mainWin-OPTNOICF-linker-switch-is-duplicated-for-debug-build
Deleted branch eng/WinClang-Remove--fmsc-version1911-compiler-switch (was 4be7bc36070c).
environment: line 1: .ToolsScriptsgit-webkit: command not found
Pushing to fork, which has no classification. Treating it as a public remote
No novel content being pushed
To https://github.com/fujii/WebKit.git
 - [deleted]                   eng/WinClang-Remove--fmsc-version1911-compiler-switch

Comment 1 Fujii Hironori 2023-10-17 18:01:26 PDT

`git push` reports the message.

PS C:\home\webkit\gc> git push -f fork
environment: line 1: .ToolsScriptsgit-webkit: command not found
Pushing to fork, which has no classification. Treating it as a public remote
No novel content being pushed
Everything up-to-date

Comment 2 Fujii Hironori 2023-10-17 18:08:29 PDT

".git/config" contains the following lines.

> [credential "https://github.com"]
> 	helper = "!f() { .\\Tools\\Scripts\\git-webkit -C https://github.com/WebKit/WebKit credentials; }; f"

Replacing "\\" with "\\\\" works around the problem.

Comment 3 Fujii Hironori 2023-10-17 18:23:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19202

Comment 4 Fujii Hironori 2023-10-17 18:25:12 PDT

This problem can be worked around by invoking "git-webkit setup" with slashs
> python ./Tools/Scripts/git-webkit setup

Not with backslashs
> python .\Tools\Scripts\git-webkit setup

Comment 5 Radar WebKit Bug Importer 2023-10-24 17:27:26 PDT

<rdar://problem/117444237>