Bug 263403

Summary: AX: AXIsolatedTree::createEmptyContent takes too long.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andres Gonzalez 2023-10-19 13:57:28 PDT 
This method should create just 2 AXIsolatedObjects, but it is still taking too long.
Comment 1 Radar WebKit Bug Importer 2023-10-19 13:57:39 PDT 
<rdar://problem/117224271>
Comment 2 Andres Gonzalez 2023-10-19 14:27:53 PDT 
Created attachment 468279 [details]
Patch
Comment 3 chris fleizach 2023-10-19 14:40:59 PDT 
Comment on attachment 468279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468279&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:99
> +    m_emptyContentTree = true;

where do we set this to false?
Comment 4 Andres Gonzalez 2023-10-19 16:38:58 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 468279 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468279&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:99
> > +    m_emptyContentTree = true;
> 
> where do we set this to false?

Never, the empty content tree is replaced with the full tree, not populated.
Comment 5 Andres Gonzalez 2023-10-23 12:12:52 PDT 
Created attachment 468304 [details]
Patch
Comment 6 Tyler Wilcock 2023-10-23 14:24:23 PDT 
Comment on attachment 468304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468304&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:369
> +    bool m_emptyContentTree { false };

Thoughts on m_isEmptyContentTree to match the member function, and to satisfy the style guide?

https://webkit.org/code-style-guidelines/#names-bool

> Precede boolean values with words like “is” and “did”.
Comment 7 Andres Gonzalez 2023-10-23 15:47:35 PDT 
Created attachment 468308 [details]
Patch
Comment 8 EWS 2023-10-24 05:49:45 PDT 
Committed 269708@main (329677707e94): <https://commits.webkit.org/269708@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468308 [details].