Bug 263423

Summary:	[Win] "ASSERTION FAILED: m_encodedDataStatus == EncodedDataStatus::SizeAvailable" for http/tests/multipart/invalid-image-data.html
Product:	WebKit	Reporter:	Fujii Hironori <Hironori.Fujii>
Component:	Images	Assignee:	Fujii Hironori <Hironori.Fujii>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, sabouhallawa, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Fujii Hironori 2023-10-19 18:43:52 PDT

[Win] "ASSERTION FAILED: m_encodedDataStatus == EncodedDataStatus::SizeAvailable" for http/tests/multipart/invalid-image-data.html

  http/tests/multipart/invalid-image-data.html [ Crash ]
  http/tests/multipart/multipart-async-image.html [ Crash ]

ASSERTION FAILED: m_encodedDataStatus == EncodedDataStatus::SizeAvailable
C:\home\webkit\gc\Source\WebCore\platform\image-decoders\ScalableImageDecoder.h(91) : setData
1   00007FF92BF01C19 WTFCrash
2   00007FF8F2485EED WTFCrashWithInfo
3   00007FF8F268A9FA WebCore::ScalableImageDecoder::setData
4   00007FF8F5FE4561 WebCore::ImageSource::setData
5   00007FF8F5FE4674 WebCore::ImageSource::dataChanged
6   00007FF8F5EC307E WebCore::BitmapImage::dataChanged
7   00007FF8F5FD24E9 WebCore::Image::setData
8   00007FF8F5B47D44 WebCore::CachedImage::updateImageData
9   00007FF8F5B480D7 WebCore::CachedImage::finishLoading
10  00007FF8F5ACF5B9 WebCore::SubresourceLoader::didFinishLoading
11  00007FF91B9F028E WebKit::WebResourceLoader::didFinishResourceLoad
12  00007FF91A86B050 IPC::callMemberFunction<WebKit::WebResourceLoader,WebKit::WebResourceLoader,void (WebCore::NetworkLoadMetrics &&),std::tuple<WebCore::NetworkLoadMetrics> >::<lambda_1>::operator()<WebCore::NetworkLoadMetrics>
13  00007FF91A86B00D std::invoke<`lambda at C:\home\webkit\gc\Source\WebKit\Platform\IPC\HandleMessage.h:135:9',WebCore::NetworkLoadMetrics>
14  00007FF91A86AFEA std::_Apply_impl<`lambda at C:\home\webkit\gc\Source\WebKit\Platform\IPC\HandleMessage.h:135:9',std::tuple<WebCore::NetworkLoadMetrics>,0>
15  00007FF91A86AFB2 std::apply<`lambda at C:\home\webkit\gc\Source\WebKit\Platform\IPC\HandleMessage.h:135:9',std::tuple<WebCore::NetworkLoadMetrics> >
16  00007FF91A86AE2F IPC::callMemberFunction<WebKit::WebResourceLoader,WebKit::WebResourceLoader,void (WebCore::NetworkLoadMetrics &&),std::tuple<WebCore::NetworkLoadMetrics> >
17  00007FF91A8669BF IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad,WebKit::WebResourceLoader,WebKit::WebResourceLoader,void (WebCore::NetworkLoadMetrics &&)>
18  00007FF91A866019 WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage
19  00007FF91B9E7137 WebKit::NetworkProcessConnection::didReceiveMessage
20  00007FF91B1DD8DA IPC::Connection::dispatchMessage
21  00007FF91B1DDB4E IPC::Connection::dispatchMessage
22  00007FF91B1DDE44 IPC::Connection::dispatchOneIncomingMessage
23  00007FF91B1E1F9B IPC::Connection::enqueueIncomingMessage::<lambda_9>::operator()
24  00007FF91B1E1F37 WTF::Detail::CallableWrapper<`lambda at C:\home\webkit\gc\Source\WebKit\Platform\IPC\Connection.cpp:1186:31',void>::call
25  00007FF92BF17DE4 WTF::Function<void ()>::operator()
26  00007FF92BF9AAFA WTF::RunLoop::performWork
27  00007FF92C06F260 WTF::RunLoop::wndProc
28  00007FF92C06F197 WTF::RunLoop::RunLoopWndProc
29  00007FF9ACF8E858 CallWindowProcW
30  00007FF9ACF8E299 DispatchMessageW
31  00007FF92C06F42D WTF::RunLoop::run

Comment 1 Fujii Hironori 2023-10-23 17:45:56 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19466

Comment 2 Radar WebKit Bug Importer 2023-10-26 18:44:30 PDT

<rdar://problem/117562402>

Comment 3 Fujii Hironori 2023-10-27 04:30:29 PDT

I tried to create a test case for Mac port, but failed.
SubresourceLoader isn't used by Mac prot on my Mac.

But, I realized this change fixes another problem (bug#36536).
I'm going to add a new test for it.

Comment 4 Fujii Hironori 2023-10-27 04:31:55 PDT

(In reply to Fujii Hironori from comment #3)
> SubresourceLoader isn't used by Mac prot on my Mac.

Not SubresourceLoader, but ScalableImageDecoder.
ScalableImageDecoder isn't used by Mac prot on my Mac.

Comment 5 EWS 2023-10-31 13:17:24 PDT

Committed 270023@main (3a699a9eda3a): <https://commits.webkit.org/270023@main>

Reviewed commits have been landed. Closing PR #19466 and removing active labels.