Bug 263487

Summary: AX: Soft-link UIAccessibility constants rather than duplicating them in iOS AX
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tyler Wilcock 2023-10-20 17:52:11 PDT
Duplicating them can cause conflicts when we try to link the framework they're defined in.
Comment 1 Radar WebKit Bug Importer 2023-10-20 17:52:19 PDT
<rdar://problem/117287269>
Comment 2 Tyler Wilcock 2023-10-20 17:59:01 PDT
Created attachment 468289 [details]
Patch
Comment 3 chris fleizach 2023-10-20 18:16:41 PDT
Comment on attachment 468289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468289&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:35
> +// FIXME: Does any AT actually consume this attributed string token?

which one? heading level?

VO should consume it
Comment 4 Tyler Wilcock 2023-10-20 19:20:00 PDT
Created attachment 468291 [details]
Patch
Comment 5 EWS 2023-10-21 10:31:50 PDT
Committed 269627@main (a96bfc4f0175): <https://commits.webkit.org/269627@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468291 [details].