Bug 263565

Summary:	Remove fatalErrorHandler()
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	XML	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	karlcow, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-10-23 16:13:14 PDT

Hi Team,

Based on Blink's commit, we can do another clean-up in XMLDocumentParser.cpp:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=186338

Just raising so I can fix it later.

Thanks!

Comment 1 Radar WebKit Bug Importer 2023-10-30 16:14:14 PDT

<rdar://problem/117710028>

Comment 2 Karl Dubost 2023-11-06 19:29:33 PST

Modification in Chromium.
https://src.chromium.org/viewvc/blink/trunk/Source/core/xml/parser/XMLDocumentParser.cpp?r1=186338&r2=186337&pathrev=186338

This is currently in 
https://searchfox.org/wubkat/rev/995ab8e866624f71cbcb82d3cf349ff9767ece4a/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp#1117-1123


and not in 
https://searchfox.org/wubkat/rev/995ab8e866624f71cbcb82d3cf349ff9767ece4a/Source/WebCore/xml/parser/XMLDocumentParser.cpp

I wonder if 
https://searchfox.org/wubkat/source/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
is used at all in the code?

Comment 3 Ahmad Saleem 2023-11-27 15:49:32 PST

PR: https://github.com/WebKit/WebKit/pull/20960