Bug 263592

Summary:	REGRESSION (269698@main): 3 TestWebKitAPI.ProcessSwap LockdownMode API tests are failing
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	WebKit2	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	achristensen, ap, bfulgham, kkinnunen, megan_gardner, pvollan, webkit-bot-watchers-bugzilla, webkit-bug-importer, wilander
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ryan Haddad 2023-10-24 08:40:35 PDT

Then following two tests are failing on iOS and macOS after https://commits.webkit.org/269698@main landed

TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode
TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement 


    TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefaultThenOptOut
        /Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8001Expected equality of these values:  runJSCheck("!!window.Highlight"_s)    Which is: true  shouldBeEnabled == ShouldBeEnabled::Yes    Which is: false/Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8001Expected equality of these values:  runJSCheck("!!window.Highlight"_s)    Which is: true  shouldBeEnabled == ShouldBeEnabled::Yes    Which is: false/Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8001Expected equality of these values:  runJSCheck("!!window.Highlight"_s)    Which is: true  shouldBeEnabled == ShouldBeEnabled::Yes    Which is: false
    TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode
        /Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8001Expected equality of these values:  runJSCheck("!!window.Highlight"_s)    Which is: true  shouldBeEnabled == ShouldBeEnabled::Yes    Which is: false

https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.ServiceWorker.WindowClientNavigateCrossOrigin&test=TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode

Comment 1 Radar WebKit Bug Importer 2023-10-24 08:40:50 PDT

<rdar://problem/117417946>

Comment 2 Ryan Haddad 2023-10-24 08:52:57 PDT Comment hidden (obsolete)

also TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement on iOS 

    TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement
        /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8001Expected equality of these values:  runJSCheck("!!window.Highlight"_s)    Which is: true  shouldBeEnabled == ShouldBeEnabled::Yes    Which is: false/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8001Expected equality of these values:  runJSCheck("!!window.Highlight"_s)    Which is: true  shouldBeEnabled == ShouldBeEnabled::Yes    Which is: false

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement

Comment 3 Ryan Haddad 2023-10-24 09:43:17 PDT

These are the tests that are failing across iOS and macOS 

TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode
TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement
TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefaultThenOptOut

https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement&test=TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefaultThenOptOut&test=TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode

Comment 4 EWS 2023-10-24 13:26:15 PDT

Committed 269729@main (c3397b4f9ae9): <https://commits.webkit.org/269729@main>

Reviewed commits have been landed. Closing PR #19496 and removing active labels.