Bug 263593

Summary:	[safe-merge-queue] Make check-status-of-pr step prettier
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Brianna Fan <bfan2>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, bfan2, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Aakash Jain 2023-10-24 09:25:23 PDT

Make check-status-of-pr step prettier.

For eg: in https://ews-build.webkit.org/#/builders/40/builds/1226, output of check-status-of-pr step is marked as failure and fills up complete screen, making the overall page not so readable. Few ideas for making it nicer:

- check-status-of-pr step shouldn't be marked as failed if a PR is pending ews checks, better to either mark it a success or warning . Better to communicate the result of checking PR status by setting that step's summary appropriately.
- "PR 19427 unsafe for merge-queue" => "PR 19427 not ready for merge-queue"  (since pending check doesn't indicate that it's unsafe)
- Nit: the result of checking (e.g.: Success, pending etc.) can be printed in same line.

Comment 1 Radar WebKit Bug Importer 2023-10-25 17:16:30 PDT

<rdar://problem/117505427>

Comment 2 Brianna Fan 2023-10-26 14:11:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19603

Comment 3 EWS 2023-10-30 17:17:39 PDT

Committed 269985@main (4235d273c502): <https://commits.webkit.org/269985@main>

Reviewed commits have been landed. Closing PR #19603 and removing active labels.