Bug 263604

Summary:	Change ExpressionRangeInfo's divot, startOffset, and endOffset to be of type unsigned.
Product:	WebKit	Reporter:	Mark Lam <mark.lam>
Component:	JavaScriptCore	Assignee:	Mark Lam <mark.lam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Mark Lam

Reported 2023-10-24 11:43:27 PDT

They are currently type int. However, they were always stored and actually ever populated with positive integer values (i.e. unsigned). We should make it clear that they are meant to contain unsigned values.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-10-24 11:43:49 PDT

<rdar://problem/117427783>

Mark Lam

Comment 2 2023-10-24 11:51:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19503

EWS

Comment 3 2023-10-24 15:48:18 PDT

Committed 269738@main (dd31388a0aef): <https://commits.webkit.org/269738@main> Reviewed commits have been landed. Closing PR #19503 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.