Bug 263699

Summary: getComputedStyle does not return correct transform
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: Joone Hur <joone>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, graouts, mattwoodrow, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/42936

Description Ahmad Saleem 2023-10-25 17:29:26 PDT
Hi Team,

While going through Blink's commit, I came across another failing test case:

Test Case: https://jsfiddle.net/5oomd14v/

^ Chrome Canary 120 and Firefox Nightly 121 shows:

matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 1)
matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 1)

While Safari Technology Preview 181 shows:

matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 1)
none

____

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=201174

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/css/ComputedStyleExtractor.cpp#857

In `computedTransform` function and in below:

if (!style.hasTransform() || is<RenderInline>(renderer))

to

if (!style.hasTransform() || !renderer)

leads to passing above but failures in WPT test cases. I haven't explored further but just wanted to raise.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-10-26 02:12:51 PDT
<rdar://problem/117523629>
Comment 2 Joone Hur 2023-10-29 00:08:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19685
Comment 3 EWS 2023-10-30 01:10:35 PDT
Committed 269920@main (1f695bbf9449): <https://commits.webkit.org/269920@main>

Reviewed commits have been landed. Closing PR #19685 and removing active labels.
Comment 4 Joone Hur 2023-11-02 11:24:28 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19896
Comment 5 Joone Hur 2023-11-02 21:59:33 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/42936
Comment 6 EWS 2023-11-10 11:54:52 PST
Committed 270557@main (f998524614f7): <https://commits.webkit.org/270557@main>

Reviewed commits have been landed. Closing PR #19896 and removing active labels.