Bug 263746

Summary:	REGRESSION (269779@main): [ macOS iOS 17 ] 3 API tests in TestWGSL is a consistent failure/crash
Product:	WebKit	Reporter:	Marta Darbinyan <darbinyan>
Component:	New Bugs	Assignee:	Tadeu Zagallo <tzagallo>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Marta Darbinyan 2023-10-26 15:00:20 PDT

Description:
 TestWGSL.WGSLConstLiteralTests.AbstractFloatLiteralDec is a consistent failure/crash since 269779@main.

This issue can be bisected to 269779@main using the command: 
run-api-tests --no-build --iterations=1 TestWGSL.WGSLConstLiteralTests.AbstractFloatLiteralDec

History:
https://results.webkit.org/?suite=api-tests&test=TestWGSL.WGSLConstLiteralTests.AbstractFloatLiteralDec

Result:
Failed
    TestWGSL.WGSLConstLiteralTests.AbstractFloatLiteralDec
        /Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/ConstLiteralTests.cpp:144Value of: is<AST::AbstractFloatLiteral>(expr)  Actual: falseExpected: true/Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/ConstLiteralTests.cpp:147Expected equality of these values:  floatLiteral.value()    Which is: 4.94066e-324  testCase.expectedValue    Which is: 1

Comment 1 Radar WebKit Bug Importer 2023-10-26 15:01:11 PDT

<rdar://problem/117553256>

Comment 2 Marta Darbinyan 2023-10-26 16:44:51 PDT

Update: More API tests are crashing and failing within the same culprit range.

Failed tests:
TestWGSL.WGSLLexerTests.SingleTokens
TestWGSL.WGSLLexerTests.SpecialTokens


History link: 
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWGSL.WGSLLexerTests.SingleTokens&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptOnPage

Errors:
TestWGSL.WGSLLexerTests.SingleTokens
        /Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:57Expected equality of these values:  result.type    Which is: 4-byte object <03-00 00-00>  type    Which is: 4-byte object <00-00 00-00>/Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:57Expected equality of these values:  result.type    Which is: 4-byte object <03-00 00-00>  type    Which is: 4-byte object <02-00 00-00>/Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:57Expected equality of these values:  result.type    Which is: 4-byte object <03-00 00-00>  type    Which is: 4-byte object <44-00 00-00>/Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:64Expected equality of these values:  result.literalValue    Which is: 0.456  literalValue    Which is: 0.456/Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:64Expected equality of these values:  result.literalValue    Which is: 0.042  literalValue    Which is: 0.042/Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:57Expected equality of these values:  result.type    Which is: 4-byte object <00-00 00-00>  type    Which is: 4-byte object <03-00 00-00>/Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:64Expected equality of these values:  result.literalValue    Which is: 6.95159e-310  literalValue    Which is: 42
    TestWGSL.WGSLLexerTests.SpecialTokens
        /Volumes/Data/worker/Apple-Sonoma-Release-Build/build/Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:57Expected equality of these values:  result.type    Which is: 4-byte object <03-00 00-00>  type    Which is: 4-byte object <44-00 00-00>

Comment 3 Tadeu Zagallo 2023-10-27 00:23:47 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19627

Comment 4 EWS 2023-10-27 10:20:43 PDT

Committed 269856@main (a8ac4a4cdd3f): <https://commits.webkit.org/269856@main>

Reviewed commits have been landed. Closing PR #19627 and removing active labels.