Bug 263796

Summary:	Adopt smart pointers in FrameLoader
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	Page Loading	Assignee:	Diego Pino <dpino>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	beidson, dpino, rniwa, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Chris Dumez 2023-10-27 12:47:48 PDT

Adopt smart pointers in FrameLoader.

Comment 1 Chris Dumez 2023-10-27 16:44:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19665

Comment 2 EWS 2023-10-28 18:50:04 PDT

Committed 269901@main (af1e21c6dbce): <https://commits.webkit.org/269901@main>

Reviewed commits have been landed. Closing PR #19665 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-10-28 18:51:14 PDT

<rdar://problem/117637326>

Comment 4 Diego Pino 2023-10-30 04:07:37 PDT

WebKitGTK Ubuntu LTS build bot, as well as other Ubuntu/Debian, build bots is failing with the following error after this commit:

```
FAILED: 
/home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-LTS-Build/build/Source/WebCore/loader/FrameLoader.cpp:3600:42: error: class template placeholder ‘WTF::CheckedPtr’ not permitted in this context
 3600 |         ForbidPromptsScope forbidPrompts(CheckedPtr { m_frame->page() }.get());
```

Comment 5 Diego Pino 2023-10-30 04:11:05 PDT

Re-opening for pull request https://github.com/webkit/webkit/pull/19709