Bug 263832

Summary: AX: 17 AccessibilityRole variants never constructed, making them effectively dead code
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cfleizach: review+, ews-feeder: commit-queue-
Patch
none
Patch none

Description Tyler Wilcock 2023-10-28 13:21:48 PDT
This hurts compile times and also hurts performance, as the compiler must generate branches for these roles that will never actually be taken.
Comment 1 Radar WebKit Bug Importer 2023-10-28 13:21:56 PDT
<rdar://problem/117631943>
Comment 2 Tyler Wilcock 2023-10-28 13:26:00 PDT
Created attachment 468383 [details]
Patch
Comment 3 Tyler Wilcock 2023-10-28 13:31:06 PDT
Created attachment 468384 [details]
Patch
Comment 4 Tyler Wilcock 2023-10-28 13:34:25 PDT
Created attachment 468385 [details]
Patch
Comment 5 EWS 2023-10-28 18:15:56 PDT
Committed 269898@main (f304f766b590): <https://commits.webkit.org/269898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468385 [details].