| Summary: | AX: AXIsolatedObject tries to cache AXPropertyName::IsPressed on macOS despite it never being used | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tyler Wilcock
2023-10-29 10:09:32 PDT
Created attachment 468402 [details]
Patch
Should the Mac be using this? There is an aria-pressed attribute (In reply to chris fleizach from comment #3) > Should the Mac be using this? There is an aria-pressed attribute The Mac does use aria-pressed via checkboxOrRadioValue(), so I think that's sufficient. (In reply to Tyler Wilcock from comment #4) > (In reply to chris fleizach from comment #3) > > Should the Mac be using this? There is an aria-pressed attribute > The Mac does use aria-pressed via checkboxOrRadioValue(), so I think that's > sufficient. Though maybe the checkboxOrRadioValue() should also be checking Element::active() like isPressed() does? Would need to investigate further, it's not clear that's the right thing to do. I think this an improvement for now though. Committed 269916@main (3c509adf5677): <https://commits.webkit.org/269916@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468402 [details]. |