Bug 263866

Summary: [GTK][WPE] JHbuild `gst-plugins-good` module fails to build on Ubuntu 20.04
Product: WebKit Reporter: Vitaly Dyackhov <vitaly>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Vitaly Dyackhov 2023-10-30 02:47:35 PDT
```
[486/747] Compiling C++ object ext/qt/libgstqmlgl.so.p/gstqtglutility.cc.o
FAILED: ext/qt/libgstqmlgl.so.p/gstqtglutility.cc.o 
/usr/bin/clang++-14 -Iext/qt/libgstqmlgl.so.p -Iext/qt -I../../Source/gst-plugins-good-1.18.4.tar.gz/ext/qt -I. -I../../Source/gst-plugins-good-1.18.4.tar.gz -I../../Source/gst-plugins-good-1.18.4.tar.gz/gst-libs -I/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/include/glib-2.0 -I/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/lib/glib-2.0/include -I/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/include/gstreamer-1.0 -I/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/include/orc-0.4 -I/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/lib/gstreamer-1.0/include -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5/QtQml -I/usr/include/x86_64-linux-gnu/qt5/QtNetwork -I/usr/include/x86_64-linux-gnu/qt5/QtQuick -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -O2 -g -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Winit-self -Wmissing-include-dirs -Wno-multichar -Wvla -Wpointer-arith -fPIC -pthread -DQT_QUICK_LIB -DQT_QML_LIB -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DHAVE_CONFIG_H -DHAVE_QT_QPA_HEADER '-DQT_QPA_HEADER=<5.12.8/QtGui/qpa/qplatformnativeinterface.h>' -DHAVE_QT_EGLFS -MD -MQ ext/qt/libgstqmlgl.so.p/gstqtglutility.cc.o -MF ext/qt/libgstqmlgl.so.p/gstqtglutility.cc.o.d -o ext/qt/libgstqmlgl.so.p/gstqtglutility.cc.o -c ../../Source/gst-plugins-good-1.18.4.tar.gz/ext/qt/gstqtglutility.cc
In file included from ../../Source/gst-plugins-good-1.18.4.tar.gz/ext/qt/gstqtglutility.cc:25:
../../Source/gst-plugins-good-1.18.4.tar.gz/ext/qt/gstqtglutility.h:35:16: warning: 'qt_opengl_native_context_from_gst_gl_context' has C-linkage specified, but returns user-defined type 'QVariant' which is incompatible with C [-Wreturn-type-c-linkage]
QVariant       qt_opengl_native_context_from_gst_gl_context     (GstGLContext * context);
               ^
../../Source/gst-plugins-good-1.18.4.tar.gz/ext/qt/gstqtglutility.cc:73:7: error: cannot initialize a parameter of type 'unsigned long *' with an rvalue of type 'typename std::remove_reference<decltype(*(&_debug))>::type *' (aka 'volatile unsigned long *')
  if (g_once_init_enter (&_debug)) {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/include/glib-2.0/glib/gthread.h:260:7: note: expanded from macro 'g_once_init_enter'
    (!g_atomic_pointer_get (location) &&                             \
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/include/glib-2.0/glib/gatomic.h:113:38: note: expanded from macro 'g_atomic_pointer_get'
    __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \
                                     ^~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
```
Comment 1 Vitaly Dyackhov 2023-10-30 02:53:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19706
Comment 2 EWS 2023-10-30 06:04:13 PDT
Committed 269936@main (6ad2b0ef2487): <https://commits.webkit.org/269936@main>

Reviewed commits have been landed. Closing PR #19706 and removing active labels.