| Summary: | REGRESSION(267944@main): wpt /css/CSS2/positioning/abspos-block-level-001.html | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=260832 https://bugs.webkit.org/show_bug.cgi?id=209735 |
||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Sam Sneddon [:gsnedders]
2023-10-30 09:30:15 PDT
Created attachment 468416 [details]
test reduction
it looks like trimmed trailing whitespace confuses out-of-flow static position logic.
2 issues: - out-of-flow boxes has to be passed in as objectReplacementCharacter (and not as truly opaque items) to icu (InlineItemsBuilder::buildBidiParagraph) - right to left inline direction (has nothing to do with bidi) needs "visually backwards" search when looking for "before" in-flow content to decide where (display: block) out-of-flow box should go (InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes) (have a local fix, will upload a patch tomorrow) Created attachment 468432 [details]
Patch
(In reply to zalan from comment #2) > Created attachment 468416 [details] > test reduction > > it looks like trimmed trailing whitespace confuses out-of-flow static > position logic. 270022@main has addressed it. Created attachment 468434 [details]
Patch
Created attachment 468436 [details]
Patch
Created attachment 468438 [details]
Patch
Created attachment 468442 [details]
[fast-cq]Patch
Committed 270069@main (f1664d74b5e3): <https://commits.webkit.org/270069@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468442 [details]. |