Bug 263919

Summary:	REGRESSION (267685@main): lldb-webkit-test is failing with TypeError: add_tree() missing 1 required positional argument: 'starting_subdirectory'
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	Tools / Tests	Assignee:	Sam Sneddon [:gsnedders] <gsnedders>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, gsnedders, jbedard, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=261108

Description Karl Rackler 2023-10-30 14:06:21 PDT

lldb-webkit-test is failing on Sonoma since bring up: https://build.webkit.org/#/builders/947/builds/1
lldb-webkit-test is failing on Ventura since about two months ago starting with build: https://build.webkit.org/#/builders/708/builds/3371

Traceback (most recent call last):
  File "/Volumes/Data/worker/Apple-Sonoma-Release-AppleSilicon-WK2-Tests/build/Tools/Scripts/test-lldb-webkit", line 145, in <module>
    sys.exit(main())
  File "/Volumes/Data/worker/Apple-Sonoma-Release-AppleSilicon-WK2-Tests/build/Tools/Scripts/test-lldb-webkit", line 139, in main
    tester.add_tree(host.filesystem.join(webkit_root, 'Tools', 'lldb'))
TypeError: add_tree() missing 1 required positional argument: 'starting_subdirectory'

Comment 1 Radar WebKit Bug Importer 2023-10-30 14:07:33 PDT

<rdar://problem/117704731>

Comment 2 Alexey Proskuryakov 2023-10-30 14:18:23 PDT

Must be caused by https://commits.webkit.org/267685@main

Comment 3 Sam Sneddon [:gsnedders] 2023-11-02 11:22:36 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19895

Comment 4 EWS 2023-11-02 13:44:07 PDT

Committed 270137@main (3b3a233a19ae): <https://commits.webkit.org/270137@main>

Reviewed commits have been landed. Closing PR #19895 and removing active labels.

Comment 5 Sam Sneddon [:gsnedders] 2023-11-03 06:54:23 PDT

https://build.webkit.org/#/builders/947/builds/615 indeed now shows it passing.