Bug 263960

Summary:	[CSSOM] Stylesheet::insertRule shoud return index on successful insertion
Product:	WebKit	Reporter:	Matthieu Dubet <m_dubet>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Matthieu Dubet 2023-10-31 02:36:32 PDT

https://drafts.csswg.org/cssom/#insert-a-css-rule

Step 8 : Return index.

We return a constant -1 for historical reason, time to respect the spec

Comment 1 Radar WebKit Bug Importer 2023-10-31 02:36:51 PDT

<rdar://problem/117730318>

Comment 2 Matthieu Dubet 2023-10-31 02:44:45 PDT

It's already the case 

https://github.com/WebKit/WebKit/blob/399d66f88e336da795cf2ed2836dee80af046b19/Source/WebCore/css/CSSStyleSheet.cpp#L367


And addRule returns -1 per spec

https://drafts.csswg.org/cssom/#insert-a-css-rule:~:text=index%20as%20arguments.-,Return%20%2D1.,-Authors%20should%20not