Bug 264130

Summary:	GlyphData.isValid() audit
Product:	WebKit	Reporter:	fantasai <fantasai.bugs>
Component:	Text	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mmaxfield, vitor.roriz, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari 17
Hardware:	Unspecified
OS:	Unspecified

Description fantasai 2023-11-02 20:11:29 PDT

I'm reviewing some code and noticed that some places use GlyphData.isValid() and other places use GlyphData.glyph and other places use GlyphData.font to check whether the GlyphData is valid or not.

We should probably be consistent, and probably use .isValid().

See https://github.com/WebKit/WebKit/commit/4535075b56fdb33a076f51fe92cd0bb8832797c8 and https://github.com/WebKit/WebKit/commit/ac25c7819037b1df2d448fca20dbfba7f96ca69c

Comment 1 Radar WebKit Bug Importer 2023-11-03 07:50:39 PDT

<rdar://problem/117905809>

Comment 2 EWS 2023-11-06 16:47:06 PST

Committed 270299@main (ef2295446d89): <https://commits.webkit.org/270299@main>

Reviewed commits have been landed. Closing PR #20006 and removing active labels.