Bug 264184

Summary:

REGRESSION(264666@main): Layout of the <tspan> elements inside a <textPath> is incorrect

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=257160

Attachments:

Description	Flags
test case	none

Description Said Abou-Hallawa 2023-11-03 16:12:41 PDT

Created attachment 468478 [details]
test case

Open the attached test case.

Result: The layout of the text inside the circle is incorrect.

This affects rendering of the MDN home page: https://developer.mozilla.org/en-US/. This is a regression of 264666@main which was the fix of bug 257160.

Comment 1 Said Abou-Hallawa 2023-11-03 16:13:16 PDT

rdar://117911214

Comment 2 Nikolas Zimmermann 2023-11-03 16:29:40 PDT

Thanks Said dir the reduction. I can have a look early next week…

Comment 3 Nikolas Zimmermann 2023-12-04 02:43:35 PST

Working on it.

Comment 4 Nikolas Zimmermann 2023-12-04 04:44:12 PST

Pull request: https://github.com/WebKit/WebKit/pull/21271

Comment 5 Nikolas Zimmermann 2023-12-04 04:46:00 PST

Got a fix, and incorporated Saids testcase as new test in the PR. However I failed to make a proper reftest for this, as HTML/CSS is missing the primitives to layout text on path, and it's hard to simulate it in a cross-platform way, unless resorting to e.g. Ahem font etc. -- I didn't have the time to investigate, and also don't want to hold back the regression fix any longer.

Comment 6 EWS 2023-12-13 11:41:26 PST

Committed 271996@main (79238bc8e2d6): <https://commits.webkit.org/271996@main>

Reviewed commits have been landed. Closing PR #21271 and removing active labels.