Bug 264285

Summary: [ iOS ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html is a constant text failure
Product: WebKit Reporter: Dawn Morningstar <Morningstar>
Component: New BugsAssignee: sideshowbarker <mike>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, karlcow, mike, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 252223    

Description Dawn Morningstar 2023-11-06 13:57:14 PST 
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html 
is a constant text failure on iOS and has been failing since it was introduced 267491@main https://commits.webkit.org/267491@main

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Finteractive-elements%2Fthe-summary-element%2Finteractive-content.html 

DIFF:
--- /Volumes/Data/worker/iOS-17-Simulator-WPT-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt
+++ /Volumes/Data/worker/iOS-17-Simulator-WPT-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-actual.txt
@@ -1,4 +1,3 @@
-OPEN FILE PANEL
  anchor element
 SVG anchor element
 
@@ -8,7 +7,7 @@
 
 This is clickable summary text
 
-PASS Clicking on non-interactive child of a <summary> opens its <details>
+FAIL Clicking on non-interactive child of a <summary> opens its <details> assert_true: expected true got false
 PASS Clicking an <a> link doesn’t open <details>
 PASS Clicking an SVG <a> link doesn’t open <details>
 PASS Clicking an HTML <a> link in an SVG <foreignObject> doesn’t open <details>
@@ -17,11 +16,11 @@
 PASS Clicking the content of an <embed> doesn’t open <details>
 PASS Clicking in an <iframe> doesn’t open <details>
 PASS Clicking an <img> with a “usemap†attribute doesn’t open <details>
-PASS Clicking an <img> without a “usemap†attribute opens <details>
+FAIL Clicking an <img> without a “usemap†attribute opens <details> assert_true: expected true got false
 PASS Clicking an <input type=button> doesn’t open <details>
 PASS Clicking an <input type=reset> doesn’t open <details>
 PASS Clicking an <input type=submit> doesn’t open <details>
-PASS Clicking an <input type=text> doesn’t open <details>
+FAIL Clicking an <input type=text> doesn’t open <details> assert_false: expected false got true
 PASS Clicking an <input type=search> doesn’t open <details>
 PASS Clicking an <input type=tel> doesn’t open <details>
 PASS Clicking an <input type=url> doesn’t open <details>
@@ -40,6 +39,6 @@
 PASS Clicking an <input type=file> doesn’t open <details>
 PASS Clicking an <input type=image> doesn’t open <details>
 PASS Clicking a <label> doesn’t open <details>
-PASS Clicking in a <textarea> doesn’t open <details>
+FAIL Clicking in a <textarea> doesn’t open <details> assert_false: expected false got true
 PASS Clicking a <video> doesn’t open <details>
 
DIFF-URL:
https://ews-build.s3-us-west-2.amazonaws.com/iOS-17-Simulator-WPT-WK2-Tests-EWS/61a5925b-2333-clean-tree/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-diff.txt
Comment 1 Radar WebKit Bug Importer 2023-11-06 13:57:57 PST 
<rdar://problem/118018378>
Comment 2 sideshowbarker 2023-11-06 17:37:09 PST 
Is there a way I can attempt to reproduce this in my local environment?

macOS 14.2 Beta (23C5030f) + XCode 15.0 beta 8 (15A5229m)
Comment 3 Alexey Proskuryakov 2023-11-06 18:09:50 PST 
Yes, this should reproduce locally. To build for iOS, one needs to run configure-xcode-for-embedded-development once (https://webkit.org/building-webkit/), then running tests should just work with --ios-simulator.
Comment 4 sideshowbarker 2023-11-07 10:18:46 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Yes, this should reproduce locally. To build for iOS, one needs to run
> configure-xcode-for-embedded-development once
> (https://webkit.org/building-webkit/), then running tests should just work
> with --ios-simulator.

Thanks — I’m getting:

WebKitTestRunnerApp.app was not found at /opt/WebKit/WebKitBuild/Debug-iphonesimulator/WebKitTestRunnerApp.app

…after building with:

./Tools/Scripts/set-webkit-configuration 
Current settings: Configuration:Debug Arch:arm64

./Tools/Scripts/build-webkit --ios-simulator

…and invoking the test runner like this:

./Tools/Scripts/run-webkit-tests --ios-simulator imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html
Comment 5 sideshowbarker 2023-11-08 00:12:15 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20148
Comment 6 sideshowbarker 2023-11-08 00:14:57 PST 
(In reply to sideshowbarker from comment #4)
> 
> Thanks — I’m getting:
> 
> WebKitTestRunnerApp.app was not found at
> /opt/WebKit/WebKitBuild/Debug-iphonesimulator/WebKitTestRunnerApp.app

Nevermind — that was because I hadn’t installed the iOS Simulator SDK in XCode
Comment 7 EWS 2023-11-17 19:14:23 PST 
Committed 270924@main (8d8e58ab0f77): <https://commits.webkit.org/270924@main>

Reviewed commits have been landed. Closing PR #20148 and removing active labels.