Bug 264297

Summary:	REGRESSION (270226@main): Profiling symbols missing from JavaScriptCore.framework
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	JavaScriptCore	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	263697
Bug Blocks:

Description David Kilzer (:ddkilzer) 2023-11-06 15:37:51 PST

Profiling symbols missing from JavaScriptCore.framework.

This happened after introducing `libJavaScriptCore.a` in 270226@main since these two lines were moved from `JavaScriptCore.xcconfig` to `libJavaScriptCore.xcconfig` instead of to `BaseTarget.xcconfig`, which caused `-fprofile-instr-generate` not to be included when linking `JavaScriptCore.framework`:

```
CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING = $(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_$(ENABLE_LLVM_PROFILE_GENERATION));
CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_ENABLE_LLVM_PROFILE_GENERATION = YES;
```

Comment 1 Radar WebKit Bug Importer 2023-11-06 15:38:13 PST

<rdar://problem/118023550>

Comment 2 David Kilzer (:ddkilzer) 2023-11-06 15:43:26 PST

Pull request: https://github.com/WebKit/WebKit/pull/20070

Comment 3 EWS 2023-11-06 20:00:58 PST

Committed 270306@main (60d419eb1b25): <https://commits.webkit.org/270306@main>

Reviewed commits have been landed. Closing PR #20070 and removing active labels.