Bug 264434

Summary:	Move the selfNeedsLayout() check out of RenderElement::repaintAfterLayoutIfNeeded()
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Layout and Rendering	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2023-11-08 13:55:56 PST

RenderElement::repaintAfterLayoutIfNeeded() shouldn't be consulting selfNeedsLayout() internally; this is confusing (maybe wrong), and repaintAfterLayoutIfNeeded() is called from RenderLayer code where we're outside of layout.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-11-08 13:56:51 PST

<rdar://problem/118138171>

Simon Fraser (smfr)

Comment 2 2023-11-08 14:01:30 PST

Pull request: https://github.com/WebKit/WebKit/pull/20188

EWS

Comment 3 2023-11-08 16:21:57 PST

Committed 270412@main (e6d3796b1e08): <https://commits.webkit.org/270412@main> Reviewed commits have been landed. Closing PR #20188 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.