Bug 264565

Summary: Add missing 'optional' for 'setConfiguration' in 'RTCPeerConnection.idl' as per WebIDL Specification
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: WebRTCAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: BrowserCompat, InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-11-10 03:58:46 PST
Hi Team,

Similar to bug 264564, it is about another alignment with web-spec and add missing 'optional' bit to progress another WPT test:

Web-Spec: https://w3c.github.io/webrtc-pc/#interface-definition

Current: undefined setConfiguration(RTCConfiguration configuration);

Expected: undefined setConfiguration(optional RTCConfiguration configuration = {});

___

WPT Test: https://wpt.live/webrtc/idlharness.https.window.html

^ From it, it progresses > RTCPeerConnection interface: operation setConfiguration(optional RTCConfiguration)

___

Just wanted to raise, so we can fix it.

Adding relevant tags as well.

Thanks!
Comment 1 EWS 2023-11-11 16:52:03 PST
Committed 270607@main (4a22b9997c9a): <https://commits.webkit.org/270607@main>

Reviewed commits have been landed. Closing PR #20345 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-11-11 16:53:14 PST
<rdar://problem/118282541>