Bug 264695
| Summary: | Use dynamicDowncast<T> more in the DOM | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | DOM | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Use dynamicDowncast<T> more in the DOM instead of is<T>() + downcast<T>(). It is less error-prone and often results in more concise code. I am also hoping to have downcast<>() do a type check on release builds in the future. It is currently too expensive to do so but it may become affordable if we use dynamicDowncast<T>() instead when possible.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/20384
EWS
Committed 270617@main (b1c357dd6e0f): <https://commits.webkit.org/270617@main>
Reviewed commits have been landed. Closing PR #20384 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/118305393>