Bug 264905

Summary: Sync 'RTCRtpScriptTransform.idl' with WebIDL Specification
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, WPTImpact
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-11-15 15:59:34 PST
Hi Team,

While looking into browser specific failures in WebRTC, I noticed that we fail few 'idlharness' tests for 'RTCRtpScriptTransform' and while looking into web specification, I noticed two things, which in my local testing progress failing tests:

Web-Spec: https://www.w3.org/TR/webrtc-encoded-transform/#RTCRtpScriptTransformer-interfaces

WebKit Source: Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl

Current:

] interface RTCRtpScriptTransform : EventTarget {

To:

] interface RTCRtpScriptTransform {

and

Current:

[CallWith=CurrentGlobalObject] constructor(Worker worker, any options, optional sequence<object> transfer);

To:

[CallWith=CurrentGlobalObject] constructor(Worker worker, optional any options, optional sequence<object> transfer);


____


Just wanted to raise, so we can fix it. Only Firefox Nightly 121 passes them yet, so not adding 'BrowserCompat' tag.

Thanks!
Comment 2 Radar WebKit Bug Importer 2023-11-22 16:00:14 PST
<rdar://problem/118728503>
Comment 3 youenn fablet 2023-11-30 22:59:54 PST
Pull request: https://github.com/WebKit/WebKit/pull/21145
Comment 4 EWS 2023-12-01 06:34:12 PST
Committed 271380@main (91ff5d82ae24): <https://commits.webkit.org/271380@main>

Reviewed commits have been landed. Closing PR #21145 and removing active labels.