Bug 264931
| Summary: | [WebM] MediaPlayerPrivateWebM can never enter in error state | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
The SourceBufferParserWebM that the MediaPlayerPrivateWebM is using can detect errors.
However, the boolean it sets when an error occurs is never read:
https://searchfox.org/wubkat/rev/7753b1fdea4b4605b4851dec61966b8b7247302a/Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm#1083-1088
And so when playback fails, nothing happen and all you get is a black screen.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118499989>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/20655
EWS
Committed 270938@main (15b788c586a8): <https://commits.webkit.org/270938@main>
Reviewed commits have been landed. Closing PR #20655 and removing active labels.