Bug 264934

Summary:	[GStreamer] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-registerprocessor-called-on-globalthis.https is flaky crash
Product:	WebKit	Reporter:	Philippe Normand <philn>
Component:	Platform	Assignee:	Philippe Normand <philn>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, cdumez, vitaly, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Philippe Normand 2023-11-16 03:07:02 PST

Thread 1 (Thread 0x7f9fd0ff9640 (LWP 692503)):
#0  std::__uniq_ptr_impl<WebCore::AudioChannel, std::default_delete<WebCore::AudioChannel> >::_M_ptr() const (this=0x0) at /usr/include/c++/12.2.0/bits/unique_ptr.h:191
#1  0x00007fb5cab1fe22 in std::unique_ptr<WebCore::AudioChannel, std::default_delete<WebCore::AudioChannel> >::get() const (this=0x0) at /usr/include/c++/12.2.0/bits/unique_ptr.h:462
#2  0x00007fb5ccac812a in std::unique_ptr<WebCore::AudioChannel, std::default_delete<WebCore::AudioChannel> >::operator->() const (this=0x0) at /usr/include/c++/12.2.0/bits/unique_ptr.h:455
#3  0x00007fb5ccac2698 in WebCore::AudioBus::zero() (this=0x7f9fc20e1140) at /app/webkit/Source/WebCore/platform/audio/AudioBus.cpp:86
#4  0x00007fb5ccad1b86 in WebCore::AudioDestination::callRenderCallback(WebCore::AudioBus*, WebCore::AudioBus*, unsigned long, WebCore::AudioIOPosition const&) (this=0x7fb5a9e01d80, sourceBus=0x0, destinationBus=0x7f9fc20e1140, framesToProcess=128, outputPosition=...) at /app/webkit/Source/WebCore/platform/audio/AudioDestination.h:110
#5  0x00007fb5ccb21e6a in webKitWebAudioSrcRenderAndPushFrames(WTF::GRefPtr<_GstElement> const&, WTF::GRefPtr<_GstBuffer>&&) (element=..., buffer=...) at /app/webkit/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:353
#6  0x00007fb5ccb221b6 in operator()() (__closure=0x7f9fc20cd488) at /app/webkit/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:401
#7  0x00007fb5ccb230da in WTF::Detail::CallableWrapper<webKitWebAudioSrcRenderIteration(WebKitWebAudioSrc*)::<lambda()>, void>::call(void) (this=0x7f9fc20cd480) at /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Function.h:53
#8  0x00007fb5c5223c41 in WTF::Function<void ()>::operator()() const (this=0x7f9fc21a05d8) at /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Function.h:82
#9  0x00007fb5cab9ef94 in operator()(WebCore::ScriptExecutionContext&) (__closure=0x7f9fc21a05d8) at /app/webkit/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:151
#10 0x00007fb5caba5404 in WTF::Detail::CallableWrapper<WebCore::DefaultAudioDestinationNode::dispatchToRenderThreadFunction()::<lambda(WTF::Function<void()>&&)>::<lambda(WebCore::ScriptExecutionContext&)>, void, WebCore::ScriptExecutionContext&>::call(WebCore::ScriptExecutionContext &) (this=0x7f9fc21a05d0, in#0=...) at /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Function.h:53
#11 0x00007fb5ca530f2d in WTF::Function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const (this=0x7f9fc20cd4a0, in#0=...) at /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Function.h:82
#12 0x00007fb5cacb325b in WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext&) (this=0x7f9fc20cd4a0, context=...) at /app/webkit/Source/WebCore/dom/ScriptExecutionContext.h:223
#13 0x00007fb5cdbb274f in WebCore::WorkerDedicatedRunLoop::Task::performTask(WebCore::WorkerOrWorkletGlobalScope*) (this=0x7f9fc20cd4a0, context=0x7fb4c912a210) at /app/webkit/Source/WebCore/workers/WorkerRunLoop.cpp:286
#14 0x00007fb5cdbb214b in WebCore::WorkerDedicatedRunLoop::runInMode(WebCore::WorkerOrWorkletGlobalScope*, WebCore::ModePredicate const&) (this=0x7fb5a9c3d4a0, context=0x7fb4c912a210, predicate=...) at /app/webkit/Source/WebCore/workers/WorkerRunLoop.cpp:221
#15 0x00007fb5cdbb1ad2 in WebCore::WorkerDedicatedRunLoop::run(WebCore::WorkerOrWorkletGlobalScope*) (this=0x7fb5a9c3d4a0, context=0x7fb4c912a210) at /app/webkit/Source/WebCore/workers/WorkerRunLoop.cpp:155
#16 0x00007fb5cdbb06d3 in WebCore::WorkerOrWorkletThread::runEventLoop() (this=0x7fb5a9b2a080) at /app/webkit/Source/WebCore/workers/WorkerOrWorkletThread.cpp:113
#17 0x00007fb5cdbb0ba4 in WebCore::WorkerOrWorkletThread::workerOrWorkletThread() (this=0x7fb5a9b2a080) at /app/webkit/Source/WebCore/workers/WorkerOrWorkletThread.cpp:187
#18 0x00007fb5cab5e5ff in operator()() const (__closure=0x7fb5a9db7d58) at /app/webkit/Source/WebCore/Modules/webaudio/AudioWorkletThread.cpp:68
#19 0x00007fb5cab6ba88 in WTF::Detail::CallableWrapper<WebCore::AudioWorkletThread::createThread()::<lambda()>, void>::call(void) (this=0x7fb5a9db7d50) at /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Function.h:53
#20 0x00007fb5c5223c41 in WTF::Function<void ()>::operator()() const (this=0x7f9fd0ff8b50) at /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Function.h:82
#21 0x00007fb5c868352d in WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) (newThreadContext=0x7fb5a98436a0) at /app/webkit/Source/WTF/wtf/Threading.cpp:258
#22 0x00007fb5c873bd87 in WTF::wtfThreadEntryPoint(void*) (context=0x7fb5a98436a0) at /app/webkit/Source/WTF/wtf/posix/ThreadingPOSIX.cpp:243
#23 0x00007fb5b96a625a in start_thread (arg=<optimized out>) at pthread_create.c:442
#24 0x00007fb5b972efc4 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Comment 1 Philippe Normand 2023-11-17 08:54:39 PST

Adding Chris in CC.

This is a bit odd, we have an AudioBus storing at least one null channel in its m_channels. I haven't understood how this is possible yet. Maybe Chris would have an idea?

Of course, I cannot reproduce this flaky crash...

Comment 2 Philippe Normand 2023-11-21 10:30:34 PST

http/wpt/webaudio/the-audio-api/the-audioworklet-interface/exposed-properties.https.html also.

Comment 3 Philippe Normand 2024-01-05 04:32:20 PST

*** Bug 267126 has been marked as a duplicate of this bug. ***

Comment 4 Philippe Normand 2024-01-06 05:25:07 PST

Pull request: https://github.com/WebKit/WebKit/pull/22464

Comment 5 EWS 2024-01-08 07:43:00 PST

Committed 272761@main (1fdb9251bb08): <https://commits.webkit.org/272761@main>

Reviewed commits have been landed. Closing PR #22464 and removing active labels.

Comment 6 Radar WebKit Bug Importer 2024-01-08 07:44:19 PST

<rdar://problem/120649517>

Comment 7 Philippe Normand 2024-01-20 04:46:09 PST

*** Bug 264729 has been marked as a duplicate of this bug. ***