Bug 265025
| Summary: | Correcting menu button event trigger location | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | don.olmstead, fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | DoNotImportToRadar, PlatformOnly |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's Commit, I came across 'Windows' specific fix due to 'contextmenu' keyboard key.
Blink Commit: https://chromium.googlesource.com/chromium/blink/+/d240a9d4fd0f048d4492293d15f6f89ed1509364
WebKit Source: https://searchfox.org/wubkat/rev/114aa2c8594807cbc34dd5dff48a9e2addfd1e00/Source/WebCore/page/EventHandler.cpp#3478
This compiles:
} else if (focusedElement) {
IntRect boundingBoxRect = focusedElement->boundsInRootViewSpace();
location = IntPoint(boundingBoxRect.center());
___
Although the test will fail on 'mac' and since I was not able to test on 'Windows', so I am just raising it, if you want to merge or have issue with 'win-cairo' port.
If it is not reproducible then please close.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118771259>