Bug 265056

Summary: AX: Cache AccessibilityText eagerly
Product: WebKit Reporter: Joshua Hoffman <jhoffman23>
Component: AccessibilityAssignee: Joshua Hoffman <jhoffman23>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Joshua Hoffman
Reported 2023-11-17 11:37:44 PST
AccessibilityText should be cached eagerly to avoid main-thread hits.
Attachments
Patch (2.92 KB, patch)
2023-11-17 12:07 PST, Joshua Hoffman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-11-17 11:37:53 PST
<rdar://problem/118574320>
Joshua Hoffman
Comment 2 2023-11-17 12:07:57 PST
Created attachment 468654 [details] Patch
chris fleizach
Comment 3 2023-11-17 17:14:27 PST
Comment on attachment 468654 [details] Patch Do you think this test is related? TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded Actual: falseExpected: true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"] Actual: falseExpected: true
chris fleizach
Comment 4 2023-11-17 17:14:27 PST
Comment on attachment 468654 [details] Patch Do you think this test is related? TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded Actual: falseExpected: true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"] Actual: falseExpected: true
Joshua Hoffman
Comment 5 2023-11-17 18:11:47 PST
(In reply to chris fleizach from comment #4) > Comment on attachment 468654 [details] > Patch > > Do you think this test is related? > > TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded > > /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/ > Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded Actual: > falseExpected: > true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/ > TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath > hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"] > Actual: falseExpected: true I wouldn’t think it’s related since this patch only touches the isolated tree and this is an iOS failure.
EWS
Comment 6 2023-11-27 12:30:44 PST
Committed 271161@main (1cf46fbe9b7b): <https://commits.webkit.org/271161@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468654 [details].
Note You need to log in before you can comment on or make changes to this bug.