Bug 265108

Summary:	Initial <input type=checkbox switch> animation support
Product:	WebKit	Reporter:	Anne van Kesteren <annevk>
Component:	Forms	Assignee:	Fujii Hironori <Hironori.Fujii>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, Hironori.Fujii, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	259380

Description Anne van Kesteren 2023-11-19 08:51:36 PST

Comment 1 Anne van Kesteren 2023-11-19 08:59:35 PST

Pull request: https://github.com/WebKit/WebKit/pull/20724

Comment 2 EWS 2023-11-26 05:58:22 PST

Committed 271118@main (0a64dd544211): <https://commits.webkit.org/271118@main>

Reviewed commits have been landed. Closing PR #20724 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-11-26 05:59:16 PST

<rdar://problem/118805169>

Comment 4 Fujii Hironori 2023-11-26 11:57:06 PST

Windows port can't compile. I'm going to reuse this ticket to fix the problem.

C:\webkit\Source\WebCore\rendering\style\RenderStyle.h(381,17): error: inline function 'WebCore::RenderStyle::hasEffectiveAppearance' is not defined [-Werror,-Wundefined-inline]
  381 |     inline bool hasEffectiveAppearance() const;
      |                 ^
C:\webkit\Source\WebCore\html/CheckboxInputType.cpp(143,43): note: used here
  143 |     ASSERT(element()->renderer()->style().hasEffectiveAppearance());
      |                                           ^
1 error generated.

Comment 5 Fujii Hironori 2023-11-26 12:06:20 PST

Pull request: https://github.com/WebKit/WebKit/pull/20910

Comment 6 EWS 2023-11-26 12:10:05 PST

Committed 271125@main (f3616fd9bff9): <https://commits.webkit.org/271125@main>

Reviewed commits have been landed. Closing PR #20910 and removing active labels.