Bug 265119

Summary: FontCascade::glyphDataForCharacter is a somewhat expensive call
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

Description zalan 2023-11-19 20:25:21 PST 
ssia
Comment 1 zalan 2023-11-19 20:27:24 PST 
Created attachment 468668 [details]
Patch
Comment 2 Antti Koivisto 2023-11-19 23:53:57 PST 
Comment on attachment 468668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468668&action=review

> Source/WebCore/rendering/RenderText.cpp:309
> +    std::array<bool, 256> hasSeen = { false };

std::bitset is bit more compact
Comment 3 zalan 2023-11-20 06:04:01 PST 
Created attachment 468677 [details]
Patch
Comment 4 zalan 2023-11-20 06:09:03 PST 
Created attachment 468679 [details]
[fast-cq]Patch
Comment 5 EWS 2023-11-20 07:16:51 PST 
Committed 270976@main (8b7f6c1f1080): <https://commits.webkit.org/270976@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468679 [details].
Comment 6 Radar WebKit Bug Importer 2023-11-20 07:18:29 PST 
<rdar://problem/118652566>