Bug 265140

Summary:	[LBSE] Implement support for filters
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	SVG	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	rbuis, sabouhallawa, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	265134

Description Nikolas Zimmermann 2023-11-20 08:15:21 PST

This affects at least the following tests in the svg/ subdirectory (taken from LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations):

svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg                                              [ ImageOnlyFailure ]
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg                                              [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-blend-01-b.svg                                                 [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-color-01-b.svg                                                 [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-composite-02-b.svg                                             [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-comptran-01-b.svg                                              [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-conv-01-f.svg                                                  [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-diffuse-01-f.svg                                               [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-example-01-b.svg                                               [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-felem-01-b.svg                                                 [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-light-01-f.svg                                                 [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-light-04-f.svg                                                 [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-morph-01-f.svg                                                 [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-offset-01-b.svg                                                [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-specular-01-f.svg                                              [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-tile-01-b.svg                                                  [ ImageOnlyFailure ]
svg/W3C-SVG-1.1/filters-turb-02-f.svg                                                  [ ImageOnlyFailure ]
svg/batik/filters/filterRegions.svg                                                    [ ImageOnlyFailure ]
svg/batik/text/smallFonts.svg                                                          [ ImageOnlyFailure ]
svg/batik/text/textEffect3.svg                                                         [ ImageOnlyFailure ]
svg/batik/text/textFeatures.svg                                                        [ ImageOnlyFailure ]
svg/custom/feComponentTransfer-Discrete.svg                                            [ Failure ]
svg/custom/feComponentTransfer-Gamma.svg                                               [ Failure ]
svg/custom/feComponentTransfer-Linear.svg                                              [ Failure ]
svg/custom/feComponentTransfer-Table.svg                                               [ Failure ]
svg/custom/image-with-transform-clip-filter.svg                                        [ Failure ]
svg/custom/local-url-reference-filter.html                                             [ ImageOnlyFailure ]
svg/custom/recursive-filter.svg                                                        [ Failure ]
svg/custom/resource-invalidate-on-target-update.svg                                    [ Failure ]
svg/custom/resources-css-scaled.html                                                   [ ImageOnlyFailure ]
svg/custom/text-filter.svg                                                             [ Failure ]
svg/custom/visibility-override-filter.svg                                              [ Failure ]
svg/dom/SVGFEFloodElement-filter-standard-attributes.svg                               [ ImageOnlyFailure ]
svg/filters/big-height-filter.svg                                                      [ ImageOnlyFailure ]
svg/filters/big-sized-filter-2.svg                                                     [ ImageOnlyFailure ]
svg/filters/big-sized-filter.svg                                                       [ ImageOnlyFailure ]
svg/filters/big-width-filter.svg                                                       [ ImageOnlyFailure ]
svg/filters/css-filter-specified-on-svg-root.html                                      [ ImageOnlyFailure ]
svg/filters/css-repaint-reference-filter-on-root.html                                  [ Failure ]
svg/filters/feBlend-all-blendmodes.svg                                                 [ ImageOnlyFailure ]
svg/filters/feColorMatrix-saturate.svg                                                 [ ImageOnlyFailure ]
svg/filters/feColorMatrix-values.svg                                                   [ ImageOnlyFailure ]
svg/filters/feComposite-background-rect-control-operators.svg                          [ ImageOnlyFailure ]
svg/filters/feComposite.svg                                                            [ ImageOnlyFailure ]
svg/filters/feCompositeOpaque.html                                                     [ ImageOnlyFailure ]
svg/filters/feConvolveFilter-y-bounds.svg                                              [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-invalid-targetX.svg                                       [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-invalid-targetY.svg                                       [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg                            [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg                            [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-negative-orderX.svg                                       [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-negative-orderY.svg                                       [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-non-integral-order.svg                                    [ ImageOnlyFailure ]
svg/filters/feConvolveMatrix-zero-divisor.svg                                          [ ImageOnlyFailure ]
svg/filters/feDiffuseLighting-bottomRightPixel.html                                    [ ImageOnlyFailure ]
svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg        [ ImageOnlyFailure ]
svg/filters/feDiffuseLighting-feSpotLight-dynamic-update.svg                           [ ImageOnlyFailure ]
svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg         [ ImageOnlyFailure ]
svg/filters/feDisplacementMap-color-interpolation-filters.svg                          [ ImageOnlyFailure ]
svg/filters/feDisplacementMap-filterUnits.svg                                          [ ImageOnlyFailure ]
svg/filters/feDisplacementMap.svg                                                      [ ImageOnlyFailure ]
svg/filters/feDropShadow-blur-radius.html                                              [ ImageOnlyFailure ]
svg/filters/feDropShadow-subregion.svg                                                 [ ImageOnlyFailure ]
svg/filters/feDropShadow-zero-deviation.svg                                            [ ImageOnlyFailure ]
svg/filters/feDropShadow.svg                                                           [ ImageOnlyFailure ]
svg/filters/feFlood-color-interpolation.svg                                            [ ImageOnlyFailure ]
svg/filters/feFlood-with-alpha-color.html                                              [ ImageOnlyFailure ]
svg/filters/feImage-animated-transform-on-target-rect.svg                              [ ImageOnlyFailure ]
svg/filters/feImage-change-target-id.svg                                               [ ImageOnlyFailure ]
svg/filters/feImage-color-fidelity.svg                                                 [ ImageOnlyFailure ]
svg/filters/feImage-cyclic-reference.svg                                               [ ImageOnlyFailure ]
svg/filters/feImage-element-primitive-subregion.svg                                    [ ImageOnlyFailure ]
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg [ ImageOnlyFailure ]
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse.svg    [ ImageOnlyFailure ]
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox.svg    [ ImageOnlyFailure ]
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse.svg       [ ImageOnlyFailure ]
svg/filters/feImage-late-indirect-update.svg                                           [ ImageOnlyFailure ]
svg/filters/feImage-preserveAspectRatio-all.svg                                        [ ImageOnlyFailure ]
svg/filters/feImage-reference-svg-primitive.svg                                        [ ImageOnlyFailure ]
svg/filters/feImage-remove-target.svg                                                  [ ImageOnlyFailure ]
svg/filters/feImage-self-and-other-referencing.html                                    [ ImageOnlyFailure ]
svg/filters/feImage-self-referencing.html                                              [ ImageOnlyFailure ]
svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg                [ ImageOnlyFailure ]
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg                 [ ImageOnlyFailure ]
svg/filters/feImage-target-attribute-change-with-use-indirection.svg                   [ ImageOnlyFailure ]
svg/filters/feLighting-crash.svg                                                       [ ImageOnlyFailure ]
svg/filters/feMerge.svg                                                                [ ImageOnlyFailure ]
svg/filters/feMorphology-negative-radius.html                                          [ ImageOnlyFailure ]
svg/filters/feMorphology-radius-cases.svg                                              [ ImageOnlyFailure ]
svg/filters/feOffset.svg                                                               [ ImageOnlyFailure ]
svg/filters/fePointLight-coordinates.svg                                               [ ImageOnlyFailure ]
svg/filters/feSpecularLight-premultiplied.svg                                          [ ImageOnlyFailure ]
svg/filters/feSpecularLighting-fePointLight-dynamic-update.svg                         [ ImageOnlyFailure ]
svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg       [ ImageOnlyFailure ]
svg/filters/feSpotLight-coordinates.svg                                                [ ImageOnlyFailure ]
svg/filters/feTile.svg                                                                 [ ImageOnlyFailure ]
svg/filters/feTurbulence_bad_seeds.html                                                [ ImageOnlyFailure ]
svg/filters/filter-clip.svg                                                            [ ImageOnlyFailure ]
svg/filters/filter-geometry-override.svg                                               [ ImageOnlyFailure ]
svg/filters/filter-on-filter-for-text.svg                                              [ ImageOnlyFailure ]
svg/filters/filter-on-tspan.svg                                                        [ ImageOnlyFailure ]
svg/filters/filter-placement-issue.svg                                                 [ ImageOnlyFailure ]
svg/filters/filter-rounding-issues.svg                                                 [ ImageOnlyFailure ]
svg/filters/filter-source-position.svg                                                 [ ImageOnlyFailure ]
svg/filters/filteredImage.svg                                                          [ ImageOnlyFailure ]
svg/filters/hidpi/fePointLight-coordinates.svg                                         [ ImageOnlyFailure ]
svg/filters/hidpi/feSpotLight-coordinates.svg                                          [ ImageOnlyFailure ]
svg/filters/parent-children-with-same-filter.svg                                       [ ImageOnlyFailure ]
svg/filters/repeated-drop-shadow-effects.svg                                           [ ImageOnlyFailure ]
svg/filters/sourceAlpha.svg                                                            [ ImageOnlyFailure ]
svg/filters/subRegion-in-userSpace.svg                                                 [ ImageOnlyFailure ]
svg/filters/subRegion-one-effect.svg                                                   [ ImageOnlyFailure ]
svg/filters/subRegion-two-effects.svg                                                  [ ImageOnlyFailure ]
svg/filters/svg-gaussianblur-edgeMode-duplicate.svg                                    [ ImageOnlyFailure ]
svg/foreignObject/filter.html                                                          [ ImageOnlyFailure ]
svg/repaint/filter-child-repaint.svg                                                   [ ImageOnlyFailure ]
svg/repaint/filter-repaint.svg                                                         [ ImageOnlyFailure ]

Comment 1 Radar WebKit Bug Importer 2023-11-27 08:17:28 PST

<rdar://problem/118834403>

Comment 2 Said Abou-Hallawa 2024-02-25 23:45:07 PST

Pull request: https://github.com/WebKit/WebKit/pull/25087

Comment 3 EWS 2024-06-19 22:11:31 PDT

Committed 280190@main (2e6697f25fa7): <https://commits.webkit.org/280190@main>

Reviewed commits have been landed. Closing PR #25087 and removing active labels.