Bug 265209

Summary:	Stop sending 2 Close frames from client-close_wsh
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, gsnedders, jbedard, karlcow, webkit-bug-importer
Priority:	P2	Keywords:	GoodFirstBug, InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=215773

Description Ahmad Saleem 2023-11-21 10:47:03 PST

Hi Team,

I don't know whether we use same 'python' script or same test infrastructure but came across following Blink commit, which might be something we have faced or we don't.

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/2138625fb49a80512464cf45fc1244015054c8de

WebKit Source: https://searchfox.org/wubkat/source/LayoutTests/http/tests/websocket/tests/hybi/client-close_wsh.py#21

Just wanted to get input so raising it.

Thanks!

Comment 1 Alexey Proskuryakov 2023-11-25 13:43:46 PST

Yes, we use this code in tests. Looks like it's referenced form two tests, one of which is marked as flaky:

LayoutTests/http/tests//websocket/tests/hybi/client-close-2.html
LayoutTests/http/tests//websocket/tests/hybi/client-close.html

Comment 2 Radar WebKit Bug Importer 2023-11-28 10:48:16 PST

<rdar://problem/118889240>

Comment 3 EWS 2023-12-03 16:55:39 PST

Committed 271447@main (d4b790b2d8a6): <https://commits.webkit.org/271447@main>

Reviewed commits have been landed. Closing PR #21235 and removing active labels.