Bug 265286

Summary:	[WPE] Upstream the new WPE platform API
Product:	WebKit	Reporter:	Carlos Garcia Campos <cgarcia>
Component:	WPE WebKit	Assignee:	Diego Pino <dpino>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aperez, bugs-noreply, dpino
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=266278

Description Carlos Garcia Campos 2023-11-23 06:11:01 PST

We have enough code already to see this is the way we want to go, so we can continue working upstream.

Comment 1 Carlos Garcia Campos 2023-11-23 06:34:50 PST

Pull request: https://github.com/WebKit/WebKit/pull/20848

Comment 2 EWS 2023-11-30 02:17:19 PST

Committed 271330@main (b12e7ed2ad3a): <https://commits.webkit.org/271330@main>

Reviewed commits have been landed. Closing PR #20848 and removing active labels.

Comment 3 Diego Pino 2023-12-01 03:53:35 PST

Bot WPE-Linux-64-bit-Release-Ubuntu-LTS-Build is failing with the following error:

```
/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-LTS-Build/build/Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp:114:12: error: ‘g_unix_fd_list_get’ was not declared in this scope
  114 |     return g_unix_fd_list_get(fdList.get(), handler, nullptr);
      |            ^~~~~~~~~~~~~~~~~~
```

https://build.webkit.org/#/builders/232/builds/24386

Comment 4 Diego Pino 2023-12-01 03:54:11 PST

Re-opening for pull request https://github.com/webkit/webkit/pull/21153

Comment 5 EWS 2023-12-01 04:02:31 PST

Committed 271376@main (a2701c1ad6e4): <https://commits.webkit.org/271376@main>

Reviewed commits have been landed. Closing PR #21153 and removing active labels.

Comment 6 Adrian Perez 2023-12-04 05:58:29 PST

Even with this fix I keep getting a build issue when cross-compiling using Yocto:

| /home/aperez/philips/synergy-mgl-browser/workspace/build/tmp/work/cortexa53-crypto-oe-linux/wpewebkit/2.43.upstream-20231201-r0/git/Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp: In member function 'virtual int WPE::DRM::SessionLogind::openDevice(const char*, int)':
| /home/aperez/philips/synergy-mgl-browser/workspace/build/tmp/work/cortexa53-crypto-oe-linux/wpewebkit/2.43.upstream-20231201-r0/git/Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp:115:12: error: 'g_unix_fd_list_get' was not declared in this scope
|   115 |     return g_unix_fd_list_get(fdList.get(), handler, nullptr);
|       |            ^~~~~~~~~~~~~~~~~~
 
I am going to submit a follow-up patch that fixes this for good.

Comment 7 Adrian Perez 2023-12-04 06:08:49 PST

Pull request: https://github.com/WebKit/WebKit/pull/21275

Comment 8 EWS 2023-12-04 14:34:18 PST

Committed 271511@main (906329430eb2): <https://commits.webkit.org/271511@main>

Reviewed commits have been landed. Closing PR #21275 and removing active labels.

Comment 9 Diego Pino 2023-12-12 04:59:19 PST

Re-opening for pull request https://github.com/webkit/webkit/pull/21675

Comment 10 EWS 2023-12-12 05:30:05 PST

Committed 271924@main (8c8709a0194c): <https://commits.webkit.org/271924@main>

Reviewed commits have been landed. Closing PR #21675 and removing active labels.

Comment 11 Diego Pino 2023-12-12 08:07:13 PST

Re-opening for pull request https://github.com/webkit/webkit/pull/21683

Comment 12 EWS 2023-12-12 08:34:43 PST

Committed 271935@main (a37d3931cdb0): <https://commits.webkit.org/271935@main>

Reviewed commits have been landed. Closing PR #21683 and removing active labels.