Bug 265373

Summary: [WinCairo] Read GITHUB_TOKEN from env when updating WebKitRequirements
Product: WebKit Reporter: Max Schmitt <max>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   

Max Schmitt
Reported 2023-11-27 03:26:22 PST
When we build WinCairo we receive this error sometimes: Updating WebKitRequirementsWin64.zip... No existing release found. Seeking latest release from WebKitForWindows/WebKitRequirements... HTTP Error 403: rate limit exceeded This is because there is no GitHub API token assigned to the request, so it thinks that our IP does exceed their rate limits. Solution: Read the API token from env and add it accordingly if set. Affected code: https://github.com/WebKit/WebKit/blob/2502481c805f5c8a62af86eeef6794d85dc08098/Tools/Scripts/download-github-release.py#L75 This gets called here: https://github.com/WebKit/WebKit/blob/2502481c805f5c8a62af86eeef6794d85dc08098/Tools/Scripts/update-webkit-wincairo-libs.py#L45
Attachments
Max Schmitt
Comment 1 2023-11-27 04:45:55 PST
EWS
Comment 2 2023-11-27 11:06:59 PST
Committed 271154@main (46ea518570fd): <https://commits.webkit.org/271154@main> Reviewed commits have been landed. Closing PR #20927 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-11-27 11:07:18 PST
Note You need to log in before you can comment on or make changes to this bug.