| Summary: | Web Inspector: CSS Grid Page Overlay support for masonry layout | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Razvan Caliman <rcaliman> | ||||||||
| Component: | Web Inspector | Assignee: | Razvan Caliman <rcaliman> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | inspector-bugzilla-changes, ntim, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 265382, 265383 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 468766 [details]
Screenshot of issue
Pull request: https://github.com/WebKit/WebKit/pull/20934 Created attachment 468767 [details]
Screenshot with patch applied
Created attachment 468768 [details]
Test case for masonry + writing modes
Committed 271332@main (9a3f6dd4c6a6): <https://commits.webkit.org/271332@main> Reviewed commits have been landed. Closing PR #20934 and removing active labels. |
The CSS Grid Page Overlay should correctly represent lines in a masonry layout. The CSS Grid Page Overlay is currently broken because it relies on there being grid tracks on both axes (see screenshot). Technically, there are no grid tracks in the masonry axis. Grid cells vary in dimension in the masonry axis. The masonry layout implementation is currently behind a flag ("CSS Masonry Layout") in Safari > Settings > Feature Flags.