Bug 265402
| Summary: | Add IPV6 support to built-in server for run-benchmarks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | hysu <hysu> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | hysu, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
hysu
Follow-up bug report to: https://bugs.webkit.org/show_bug.cgi?id=259835 (Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server)
`--http-server-type builtin` only serves on IPV4 at the moment. While this should be the default, we should also be able to serve on IPV6 for harnesses that require it, and be able to automatically detect which one to use.
The simplest way to implement this would be to override `address_family = socket.AF_INET6` in SimpleHTTPRequestHandler, and to switch when an address contains colons instead of periods.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118850024>
james
Pull request: https://github.com/WebKit/WebKit/pull/21008
EWS
Committed 271412@main (ecc5b337e0f9): <https://commits.webkit.org/271412@main>
Reviewed commits have been landed. Closing PR #21008 and removing active labels.