Bug 265450
| Summary: | Fix FIXME in findPreviousAndNextAttributes in RenderSVGText.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | karlcow, rbuis, sabouhallawa, webkit-bug-importer, zakr, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across one potential merge, where we still have FIXME, which the commit fixed:
Blink Commit: https://chromium.googlesource.com/chromium/blink/+/ab5b1a60d9ef3c196db20634d36c1d66c14a042f
WebKit Source: https://searchfox.org/wubkat/rev/c20f54808bd9cd41e49a640e8c20923340e4d14b/Source/WebCore/rendering/svg/RenderSVGText.cpp#104
Just wanted to raise, so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119183485>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/35677
EWS
Committed 296257@main (0beddeef1fec): <https://commits.webkit.org/296257@main>
Reviewed commits have been landed. Closing PR #35677 and removing active labels.