Bug 265551
| Summary: | [webkitscmpy] Calculating XXX@main should pass --no-replace-objects | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfan2, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
e.g.:
gsnedders@gsnedders-milk foo % git clone https://github.com/WebKit/WebKit.git
Cloning into 'WebKit'...
remote: Enumerating objects: 1175, done.
remote: Counting objects: 100% (1003/1003), done.
remote: Total 1175 (delta 1003), reused 1003 (delta 1003), pack-reused 172
Receiving objects: 100% (1175/1175), 2.50 MiB | 11.38 MiB/s, done.
Resolving deltas: 100% (1035/1035), completed with 537 local objects.
Checking objects: 100% (65536/65536), done.
Updating files: 100% (400104/400104), done.
gsnedders@gsnedders-milk foo % cd WebKit
gsnedders@gsnedders-milk WebKit % git fetch https://invent.kde.org/unmaintained/kdelibs.git v2.2.0
remote: Enumerating objects: 129602, done.
remote: Counting objects: 100% (37412/37412), done.
remote: Compressing objects: 100% (4820/4820), done.
remote: Total 129602 (delta 35302), reused 32592 (delta 32592), pack-reused 92190
Receiving objects: 100% (129602/129602), 26.53 MiB | 11.48 MiB/s, done.
Resolving deltas: 100% (100247/100247), done.
From https://invent.kde.org/unmaintained/kdelibs
* tag v2.2.0 -> FETCH_HEAD
gsnedders@gsnedders-milk WebKit % git replace --graft b33f06b05b1e58d5d9f177065e71f8878395ac70 FETCH_HEAD "$( git rev-list -n 1 b33f06b05b1e58d5d9f177065e71f8878395ac70 )"
gsnedders@gsnedders-milk WebKit % ./Tools/Scripts/git-webkit find 213213@main
Downloading setuptools-56.0.0...
Installed setuptools-56.0.0!
Downloading wheel-0.35.1...
Installed wheel-0.35.1!
Downloading pyparsing-2.4.7...
Installed pyparsing-2.4.7!
Downloading packaging-21.3.0...
Installed packaging-21.3.0!
Downloading tomli-2.0.1...
Installed tomli-2.0.1!
Downloading setuptools-scm-6.4.2...
Installed setuptools-scm-6.4.2!
Downloading six-1.16.0...
Installed six-1.16.0!
Downloading urllib3-1.26.17...
Installed urllib3-1.26.17!
Downloading rapidfuzz-2.11.1...
Installing rapidfuzz-2.11.1...
Installed rapidfuzz-2.11.1!
Downloading whichcraft-0.6.1...
Installed whichcraft-0.6.1!
Downloading mock-4.0.0...
Installing mock-4.0.0...
Installed mock-4.0.0!
Downloading requests-2.26.0...
Installed requests-2.26.0!
Downloading chardet-3.0.4...
Installed chardet-3.0.4!
Downloading idna-2.10.0...
Installed idna-2.10.0!
Downloading PySocks-1.7.1...
Installed PySocks-1.7.1!
Title: [iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down
Author: Wenson Hsieh <wenson_hsieh@apple.com>
Date: Fri Jul 28 00:31:06 2017
Revision: 219998
Hash: 10586b54fea5
Identifier: 213213@main
gsnedders@gsnedders-milk WebKit % git log -n1 10586b54fea5 | cat
commit 10586b54fea5
Author: Wenson Hsieh <wenson_hsieh@apple.com>
Date: Fri Jul 28 07:31:06 2017 +0000
[iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down
https://bugs.webkit.org/show_bug.cgi?id=174928
<rdar://problem/33584280>
Reviewed by Tim Horton.
Pulls the implementation of createDragImageForRange out into DragImageIOS, and use TextIndicator to generate a
snapshot instead of FrameSelection's snapshotting utilities. This makes snapshotting a DOMRange behave the same
way as snapshotting a dragged selection.
No way of testing TextIndicator-based snapshotting yet.
* platform/DragImage.cpp:
Guard createDragImageForRange for !PLATFORM(IOS).
* platform/ios/DragImageIOS.mm:
(WebCore::createDragImageForSelection):
Add a FIXME to point out that having an additional context flip inside the UIGraphicsImageRenderer block results
in an upside-down drag image being returned from createDragImageFromImage. This image is being flipped elsewhere
in drag initiation code, which eventually results in the correct orientation; we'll need further investigation
to remove this extraneous flip.
(WebCore::createDragImageForRange):
Canonical link: https://commits.webkit.org/191727@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
gsnedders@gsnedders-milk WebKit %
This is clearly wrong, we should end up with something that matches the canonical link. We need to pass `--no-replace-objects` in various places to ensure we end up with the canonical repo history when counting commits.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118951862>
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/58566
EWS
Committed 307542@main (1b276cac1895): <https://commits.webkit.org/307542@main>
Reviewed commits have been landed. Closing PR #58566 and removing active labels.